Skip to content

fix(cli): Don't recognize "typ" as typo in .typ files #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): Don't recognize "typ" as typo in .typ files #1328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/typos-cli/src/default_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ pub(crate) const DEFAULT_TYPES: &[(&str, &[&str])] = &[
("ts", &["*.ts", "*.tsx", "*.cts", "*.mts"]),
("twig", &["*.twig"]),
("txt", &["*.txt"]),
("typ", &["*.typ"]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is copied out of ripgrep
https://github.com/BurntSushi/ripgrep/blob/master/crates/ignore/src/default_types.rs

Changes to it could easily b lost when we do updates from ripgrep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could add a test case to make you we don't regress?

("typoscript", &["*.typoscript"]),
("usd", &["*.usd", "*.usda", "*.usdc"]),
("v", &["*.v", "*.vsh"]),
Expand Down
9 changes: 9 additions & 0 deletions crates/typos-cli/src/file_type_specifics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ pub(crate) const TYPE_SPECIFIC_DICTS: &[(&str, StaticDictConfig)] = &[
ignore_words: &[],
},
),
(
"typ", // Typst
StaticDictConfig {
ignore_idents: &[
"typ", // file extension
],
ignore_words: &[],
},
),
(
"vimscript",
StaticDictConfig {
Expand Down
Loading