[5.x]: Sibling Assets do not appear when Subfolder count is too high

[mike-moreau]

What happened?

Description

I have a filesystem with several levels of nested subfolders.

One nested folder contains 50 child folders and 16 Assets within the same parent.

Only the 50 child folders display in the table. The Assets do not display. They are not returned in the ajax request, and no pagination is displayed.

It appears that the issue is in this logic in the Asset Element's indexElements method:

cms/src/elements/Asset.php

Line 822 in de5d01d

count($assets) === (int)$elementQuery->limit

Both count($assets) === (int)$elementQuery->limit were 50 in my case.

If I comment that out and continue to the array_merge, then the subfolders and assets appear as expected.

Steps to reproduce

1. Create a folder with over 50 subfolders and some Assets

Expected behavior

All items or pagination displays.

Actual behavior

Only folders display.

Craft CMS version

5.8.21

PHP version

8.3

Operating system and version

No response

Database type and version

MySQL 8

Image driver and version

No response

Installed plugins and versions

[linear]

CMS-1743

[i-just]

Hi, thanks for reporting! I raised a PR for this.

[brandonkelly]

Craft 4.16.18 and 5.8.22 are out with that fix. Thanks again!

[mike-moreau]

Thank you!