Skip to content

fix: crash on unimplemented when populating overloads destructor entry #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
+3 −0
Merged

fix: crash on unimplemented when populating overloads destructor entry #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/Metadata/Finalizers/OverloadsFinalizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ foldOverloads(SymbolID const& contextId, std::vector<SymbolID>& functionIds, boo
MRDOCS_CHECK_OR_CONTINUE(recordInfoPtr);
auto* function = recordInfoPtr->asFunctionPtr();
MRDOCS_CHECK_OR_CONTINUE(function);
MRDOCS_CHECK_OR_CONTINUE(function->Class != FunctionClass::Destructor);

// Check if the FunctionInfo is unique
std::ranges::subrange otherFunctionIds(
Expand Down
2 changes: 2 additions & 0 deletions src/lib/Metadata/Info/Overloads.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ merge(OverloadsInfo& I, OverloadsInfo&& Other)
void
addMember(OverloadsInfo& I, FunctionInfo const& Member)
{
MRDOCS_ASSERT(Member.Class != FunctionClass::Destructor);

if (I.Members.empty())
{
I.Name = Member.Name;
Expand Down
Loading