Skip to content

2025-06 LWG Motions 10–13 std::simd #8016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

mattkretz
Copy link
Member

@mattkretz mattkretz force-pushed the motions-2025-06-lwg-13 branch from 201d660 to 38edfe3 Compare June 25, 2025 12:10
@mattkretz
Copy link
Member Author

mattkretz commented Jun 25, 2025

Oh, I somehow messed up my tree and squashed motion 11 into a Fixup commit. Will fix.
edit: fixed

@mattkretz mattkretz force-pushed the motions-2025-06-lwg-13 branch from 38edfe3 to 6efc1cc Compare June 25, 2025 12:28
@jensmaurer jensmaurer changed the title 2025-06 LWG Motions 10–13 2025-06 LWG Motions 10–13 std::simd Jun 26, 2025
@mattkretz
Copy link
Member Author

I need to call out 45ddf54, which is probably more than editorial. The paper forgot to add the simd-integral concept and that commit adds it. Needs an LWG issue, no?

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 26, 2025

It if's obviously what was meant and its definition is obvious, I'd be perfectly happy to call that editorial. @jwakely?

@mattkretz
Copy link
Member Author

simd-integral is a copy of simd-floating-point where floating_point gets replaced by integral. I certainly think it's obvious.

@jensmaurer
Copy link
Member

Please add simd-integral as a separate non-fixup commit.

@mattkretz
Copy link
Member Author

Ah, commit where the message doesn't start with 'Fixup' is meant as editorial non-fixup commit. Should I move all of them into another PR or a series of PRs?
Note that CI will fail without the simd-integral \defexposconcept unless I change \exposconcept{simd-integral} to \exposid.

@jensmaurer
Copy link
Member

jensmaurer commented Jun 27, 2025

"fixup" commits will be squashed by @tkoeppe when he merges all the pull requests, so don't appear in the history. They are intended for stuff where the incoming paper wasn't transcribed properly (e.g. missed edit or so). We don't want to be reminded of these for all eternity.

In contrast, (editorial) fixes on top of papers that were not directly shown in the paper should be a "regular" commit (with section label at the start of the commit title etc.), but can (and, in this case, should) stay in the same pull request as the paper, because related to the paper. If someone does archeology, we can clearly see the add-on fixes that were not asked for in the paper.

In this particular case, since the CI fails without the fix, we do need the add-on commit in this very same pull request.

@jwakely
Copy link
Member

jwakely commented Jun 27, 2025

It if's obviously what was meant and its definition is obvious, I'd be perfectly happy to call that editorial. @jwakely?

Yes, this seems like a straightforward consistency fix, the intent is clear.

@mattkretz mattkretz force-pushed the motions-2025-06-lwg-13 branch from 6efc1cc to eee8a03 Compare June 27, 2025 15:33
@mattkretz
Copy link
Member Author

I just noticed missing @ escapes and missing index entries for basic_mask::value_type/abi_type. Force pushed so that no fixup commit comes after editorial commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment