-
Notifications
You must be signed in to change notification settings - Fork 777
2025-06 LWG Motions 10–13 std::simd #8016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
201d660
to
38edfe3
Compare
Oh, I somehow messed up my tree and squashed motion 11 into a Fixup commit. Will fix. |
38edfe3
to
6efc1cc
Compare
I need to call out 45ddf54, which is probably more than editorial. The paper forgot to add the simd-integral concept and that commit adds it. Needs an LWG issue, no? |
It if's obviously what was meant and its definition is obvious, I'd be perfectly happy to call that editorial. @jwakely? |
simd-integral is a copy of simd-floating-point where |
Please add simd-integral as a separate non-fixup commit. |
Ah, commit where the message doesn't start with 'Fixup' is meant as editorial non-fixup commit. Should I move all of them into another PR or a series of PRs? |
"fixup" commits will be squashed by @tkoeppe when he merges all the pull requests, so don't appear in the history. They are intended for stuff where the incoming paper wasn't transcribed properly (e.g. missed edit or so). We don't want to be reminded of these for all eternity. In contrast, (editorial) fixes on top of papers that were not directly shown in the paper should be a "regular" commit (with section label at the start of the commit title etc.), but can (and, in this case, should) stay in the same pull request as the paper, because related to the paper. If someone does archeology, we can clearly see the add-on fixes that were not asked for in the paper. In this particular case, since the CI fails without the fix, we do need the add-on commit in this very same pull request. |
Yes, this seems like a straightforward consistency fix, the intent is clear. |
The two values are already defined in [simd.syn].
The name simd-type could refer to both basic_vec and basic_mask specializations. simd-vec-type is clearer and more consistent with the simd-mask-type concept.
Better name for an alias that is either a basic_vec specialization or void.
6efc1cc
to
eee8a03
Compare
I just noticed missing |
Fixes #7947
Fixes cplusplus/papers#1531
Fixes #7948
Fixes cplusplus/papers#2134
Fixes: #7949
Fixes: cplusplus/papers#1383
Fixes: #7950
Fixes: cplusplus/papers#2321