-
Notifications
You must be signed in to change notification settings - Fork 775
Wrap keywords that were \terminal{} with \keyword{} instead #7602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Please rebase. |
@ilazaric: Could you please rebase? |
0c1a7de
to
607860c
Compare
Looks good. |
Could you tell me the correctly phrased commit message? It's OK to keep things in one commit, but we should state the affected subclauses. So something like "[foo.bar, xy.zw] Use "\keyword" instead of "\terminal"". (Don't worry about changing the commit, I can do that at application time. I would just appreciate you looking up the references.) |
[expr.prim.lambda.capture], [expr.post.general]/1, [expr.await]/1, [expr.yield], [lex.bool], [lex.nullptr], [over.call.object]/2, [over.oper.general]/1, [cpp.include]/7, [stmt.return.coroutine], [stmt.return.coroutine]/2, [temp.res.general]/2 Note [stmt.return.coroutine] is changed in 0th and 2nd paragraph Alternate format: Alternate without paragraph numbers: |
My impression is that keywords should be
\keyword{<string>}
usually, no surrounding command, except inone of
grammar definitions, where they should be wrapped in a\terminal{...}
Didn't do this on a couple occurences in preprocessor.tex (
if
andelse
are in\terminal{}
args):I don't think these are quite the same meaning as keyword if
Also, there are many instances of keywords not being \keyword-ed in \tcode{} parts, this PR does not touch those
Additionally some minor cleanup
\keyword{U}
->\tcode{U}