[2022-07 LWG Motion 1] P2618R0 C++ Standard Library Issues #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tkoeppe merged 26 commits into main from motions-2022-07-lwg-1

Aug 11, 2022

Contributor

burblebee commented Jul 28, 2022 •

edited by jensmaurer

Loading

Fixes #5588
Fixes cplusplus/papers#1281
Fixes cplusplus/papers#1184
Fixes cplusplus/papers#1183
Fixes cplusplus/papers#1052

burblebee force-pushed the motions-2022-07-lwg-1 branch from 51c47c0 to 6178f52 Compare

July 28, 2022 03:50

Contributor Author

burblebee commented Jul 28, 2022

The build is failing in check-output.sh because section depr.atomics.flag was removed by this paper (the failure is in the check for "Cross references since the previous standard."). How to make the build happy?

Contributor

Mick235711 commented Jul 28, 2022 •

edited

Loading

The build is failing in check-output.sh because section depr.atomics.flag was removed by this paper (the failure is in the check for "Cross references since the previous standard."). How to make the build happy?

I'm guessing add something like

\removedxref{depr.atomics.flag}

into xrefdelta.tex may satisfy the build script.

~~But again, I'm no expert in draft LaTeX usage, so I'm not sure if this will fix it or not.~~ Yeah, this fixed the error.

jwakely reviewed

View reviewed changes

source/utilities.tex Outdated Show resolved Hide resolved

jwakely reviewed

View reviewed changes

source/utilities.tex Outdated Show resolved Hide resolved

jwakely reviewed

View reviewed changes

source/ranges.tex Outdated Show resolved Hide resolved

jwakely reviewed

View reviewed changes

source/utilities.tex Outdated Show resolved Hide resolved

jwakely reviewed

View reviewed changes

source/threads.tex Outdated Show resolved Hide resolved

jwakely requested changes

View reviewed changes

Member

jwakely left a comment

There is one error in the content, a couple of formatting problems, and a couple of no-op changes to simplify the LaTeX.

jensmaurer added this to the post-2022-07 milestone

burblebee requested a review from jwakely

July 28, 2022 21:53

jwakely approved these changes

View reviewed changes

Member

jwakely left a comment

Looks good now, thanks

burblebee added 18 commits

August 7, 2022 22:17


          LWG3564 transform_view::iterator<true>::value_type and iterator_categ…

…ory should use const F&


          LWG3617 function/packaged_task deduction guides and deducing this

c5b6a5c


          LWG3656 Inconsistent bit operations returning a count

53c83cf


          LWG3659 Consider ATOMIC_FLAG_INIT undeprecation

c61c1b6


          LWG3670 Cpp17InputIterators don't have integer-class difference types

6fbded2


          LWG3671 atomic_fetch_xor missing from stdatomic.h

50f1e24


          LWG3672 common_iterator::operator->() should return by value

0df9a20


          LWG3683 operator== for polymorphic_allocator cannot deduce template a…

da4456d

…rgument in common cases


          LWG3687 expected<cv void, E> move constructor should move

29f66da


          LWG3692 zip_view::iterator's operator<=> is overconstrained

76a86b8


          LWG3701 Make formatter<remove_cvref_t<const charT[N]>, charT> require…

62e3587

…ment explicit


          LWG3702 Should zip_transform_view::iterator remove operator<?

d29b963


          LWG3703 Missing requirements for expected<T, E> requires is_void<T>

62fe2a0


          LWG3704 LWG 2059 added overloads that might be ill-formed for sets

a7cbca7


          LWG3705 Hashability shouldn't depend on basic_string's allocator

f8f6265


          LWG3707 chunk_view::outer-iterator::value_type::size should return un…

7ecb746

…signed type


          LWG3708 take_while_view::sentinel's conversion constructor should move

d6a68e3


          LWG3709 LWG-3703 was underly ambitious

60fa43a

burblebee added 8 commits

August 7, 2022 22:17


          LWG3710 The end of chunk_view for input ranges can be const

d7a01d9


          LWG3711 Missing preconditions for slide_view constructor

0416e7e


          LWG3712 chunk_view and slide_view should not be default_initializable

ab54e00


          LWG3713 Sorted with respect to comparator (only)

d6d435a

[alg.sorting.general] Add index for definition of a sequence sorted with respect to a comparator and projection


          LWG3715 view_interface::empty is overconstrained

81b066e


          LWG3719 Directory iterators should be usable with default sentinel

8d06220


          LWG3721 Allow an arg-id with a value of zero for width in std-format-…

c519b70

…spec


          LWG3724 decay-copy should be constrained

cdd04d6

tkoeppe force-pushed the motions-2022-07-lwg-1 branch from 0d9b432 to cdd04d6 Compare

August 7, 2022 21:18

tkoeppe reviewed

View reviewed changes

source/threads.tex Show resolved Hide resolved

tkoeppe merged commit 6cce010 into main

jensmaurer deleted the motions-2022-07-lwg-1 branch

November 18, 2022 21:41

frederick-vs-ja mentioned this pull request

[ranges] Should constexpr default_sentinel_t end() be const-qualified? #5507

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment