Skip to content

fix(bridge): use real WETH addresses in README example#851

Open
Kropiunig wants to merge 1 commit intocowprotocol:mainfrom
Kropiunig:fix/bridge-sample-tokens
Open

fix(bridge): use real WETH addresses in README example#851
Kropiunig wants to merge 1 commit intocowprotocol:mainfrom
Kropiunig:fix/bridge-sample-tokens

Conversation

@Kropiunig
Copy link
Copy Markdown
Contributor

@Kropiunig Kropiunig commented Apr 5, 2026

Summary

Fixes #341

The bridge SDK README example uses non-token addresses as sample tokens, causing users to get "No path found" when running the example. This replaces them with real WETH contract addresses on Arbitrum and Base.

Test plan

  • Verified the replacement addresses are valid WETH contracts on their respective chains

Summary by CodeRabbit

  • Documentation
    • Updated bridging request example code with revised token contract addresses for supported blockchain networks to ensure accuracy across usage scenarios.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1ec0ffe0-8e04-4f5e-8ffe-82abe9242838

📥 Commits

Reviewing files that changed from the base of the PR and between a56dead and fcf0701.

📒 Files selected for processing (1)
  • packages/bridging/README.md

📝 Walkthrough

Walkthrough

The pull request updates example token addresses in the bridging SDK documentation. The sellTokenAddress parameter for Arbitrum and buyTokenAddress parameter for Base in code examples are replaced with proper WETH token contract addresses that can be successfully bridged, resolving "no path found" errors in the existing examples.

Changes

Cohort / File(s) Summary
Documentation Examples
packages/bridging/README.md
Updated token contract addresses in QuoteBridgeRequest examples. Replaced sell and buy token addresses with functional WETH contracts for Arbitrum and Base respectively across both TypeScript code snippets.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 The tokens were ghosts, not contracts at all,
So the bridge requests answered no call.
With WETH now in place, both shiny and true,
The examples will work—old made like new! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(bridge): use real WETH addresses in README example' clearly and concisely describes the main change: replacing invalid token addresses with real WETH addresses in the bridge README documentation.
Linked Issues check ✅ Passed The PR directly addresses issue #341 by replacing the non-token addresses (0xfff9976782d46cc05630d1f6ebab18b2324d6b14 and 0x0625afb445c3b6b7b929342a04a22599fd5dbb59) with the suggested real WETH addresses (Arbitrum: 0x82af49447d8a07e3bd95bd0d56f35241523fbab1 and Base: 0x4200000000000000000000000000000000000006) in both TypeScript code snippets.
Out of Scope Changes check ✅ Passed All changes are scoped to the README example documentation only, directly addressing the issue requirements with no unrelated modifications to code or other files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bridge SDK: Sample Tokens Aren't Contracts

1 participant