Skip to content

feat: format inputs and add CI defaults#6

Open
anxolin wants to merge 4 commits intomainfrom
sort-inputs-n-ci
Open

feat: format inputs and add CI defaults#6
anxolin wants to merge 4 commits intomainfrom
sort-inputs-n-ci

Conversation

@anxolin
Copy link
Copy Markdown
Contributor

@anxolin anxolin commented Feb 18, 2026

Description

Follow up on #4 with a coment from @fedgiac I didn't want to mix in the "default foundry" setup (I'd like to have a PR with just foundry as it is, and then we can do small PRs to add bits and pieces)

#4 (comment)

Testing Instructions

  1. Open Counter.t.sol

Invert the order of the imports, so they look like

import {Test} from "forge-std/Test.sol";
import {Counter} from "../src/Counter.sol";
  1. Run forge fmt
    It should invert again the imports leaving as they were
import {Counter} from "../src/Counter.sol";
import {Test} from "forge-std/Test.sol";

If you use vscode and you have a solidity plugin (like me), chances are that the IDE formats it on save already, so no even need to do step 2

@anxolin anxolin requested a review from a team as a code owner February 18, 2026 20:41
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably also add setting the default solc version. We will have to remember to bump over time, but will help keep projects reproducible.

current latest is 0.8.33 I think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good c3f3247

@anxolin anxolin requested a review from kaze-cow February 19, 2026 18:04
Copy link
Copy Markdown
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't know enough about notes to choose between this and warnings, we can just pick any of the two and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants