feat: use cache for token details and improve architecture#186
Merged
anxolin merged 1 commit intobalance-ssefrom Jan 16, 2026
Merged
feat: use cache for token details and improve architecture#186anxolin merged 1 commit intobalance-ssefrom
anxolin merged 1 commit intobalance-ssefrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses some leftovers from the hackathon.
Cache improvements
We remove a lot of RPC calls for getting over and over the: symbol, decimals, name
This info is highly cacheable and already part of a repository.
Architeture improvements
The API was depending directly from the repository layer, which should not be the case (should use the services).
Also, we have a more clear separation of reponsabilities between the ERC20 repo and the balances one.
The later is not loading token info anymore.
Test
yarn start