Skip to content

Skip file check existence for source generated file #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcoRossignoli merged 2 commits into from
Feb 21, 2021
Merged

Skip file check existence for source generated file #1091

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
090fdff
bypass local file check for source generated files
MarcoRossignoli Feb 13, 2021
32a94f7
add comments
MarcoRossignoli Feb 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/coverlet.core/Helpers/InstrumentationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ public bool EmbeddedPortablePdbHasLocalSource(string module, out string firstNot
// We verify all docs and return false if not all are present in local
// We could have false negative if doc is not a source
// Btw check for all possible extension could be weak approach
if (!_fileSystem.Exists(docName))
// We exlude from the check the autogenerated source file(i.e. source generators)
if (!_fileSystem.Exists(docName) && !docName.EndsWith(".g.cs"))
{
firstNotFoundDocument = docName;
return false;
Expand Down Expand Up @@ -172,7 +173,8 @@ public bool PortablePdbHasLocalSource(string module, out string firstNotFoundDoc
// We verify all docs and return false if not all are present in local
// We could have false negative if doc is not a source
// Btw check for all possible extension could be weak approach
if (!_fileSystem.Exists(docName))
// We exlude from the check the autogenerated source file(i.e. source generators)
if (!_fileSystem.Exists(docName) && !docName.EndsWith(".g.cs"))
{
firstNotFoundDocument = docName;
return false;
Expand Down