Skip to content

ING-695: Use cbdinocluster for test cluster creation. #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

brett19
Copy link
Member

@brett19 brett19 commented Jul 10, 2025

No description provided.

@brett19 brett19 requested review from chvck, Westwooo and Copilot July 10, 2025 18:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the test workflow to use the cbdinocluster CLI for creating and managing the Couchbase test cluster instead of custom scripts, and adds log collection on failure.

  • Install and initialize cbdinocluster in the GitHub Actions runner
  • Replace custom cluster scripts with cbdinocluster allocate, bucket/collection setup, and connection‐string export
  • Add steps to collect and upload Couchbase logs if tests fail
Comments suppressed due to low confidence (3)

.github/workflows/test.yml:30

  • [nitpick] The cbdinocluster version (v0.0.41) is hard-coded; consider parameterizing this version or defining it as a variable at the top of the workflow for easier updates.
          wget -nv -O $HOME/bin/cbdinocluster https://github.com/couchbaselabs/cbdinocluster/releases/download/v0.0.41/cbdinocluster-linux-amd64

.github/workflows/test.yml:77

  • Add a cleanup step (e.g., cbdinocluster clean) after tests (or in an always() conditional) to reliably tear down the test cluster and avoid resource leakage on GitHub runners.
        run: go test -v $(go list ./... | grep -v /contrib/)

.github/workflows/test.yml:30

  • Consider verifying the downloaded cbdinocluster binary with a checksum or GPG signature to ensure its integrity and guard against tampering.
          wget -nv -O $HOME/bin/cbdinocluster https://github.com/couchbaselabs/cbdinocluster/releases/download/v0.0.41/cbdinocluster-linux-amd64

@brett19 brett19 force-pushed the ING-695_dino-test branch 2 times, most recently from e4174b6 to 3562783 Compare July 10, 2025 18:20
Westwooo
Westwooo previously approved these changes Jul 14, 2025
@brett19 brett19 force-pushed the ING-695_dino-test branch 6 times, most recently from 7221f88 to 8acf11d Compare July 18, 2025 18:53
@brett19 brett19 force-pushed the ING-695_dino-test branch from 8acf11d to 8c0eb7c Compare July 22, 2025 17:43
@brett19 brett19 merged commit 23b6080 into master Jul 22, 2025
5 of 6 checks passed
@brett19 brett19 deleted the ING-695_dino-test branch July 22, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants