minor xref fixes for fts #2493
Merged
minor xref fixes for fts #2493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update dead reference from xref:fts:fts-response-object-schema.adoc#request[maximum number of full text search results] to xref:fts:fts-advanced-settings-bleveMaxResultWindow.adoc[bleveMaxResultWindow]
jon-strabala
commented
Feb 24, 2022
There was a problem hiding this comment.
@abhinavdangeti can you pay close attention to the change in searchfun.adoc
| @@ -142,7 +142,7 @@ For more details, refer to xref:fts:fts-sorting.adoc[Sorting Query Results]. | |||
|
|
|||
| [NOTE] | |||
| ==== | |||
| When specifying a complete full text search request with the N1QL SEARCH() function, if the value of the `size` parameter is greater than the xref:fts:fts-response-object-schema.adoc#request[maximum number of full text search results], the query ignores the `size` parameter and returns all matching results. | |||
| When specifying a complete full text search request with the N1QL SEARCH() function, if the value of the `size` parameter is greater than the xref:fts:fts-advanced-settings-bleveMaxResultWindow.adoc[bleveMaxResultWindow], the query ignores the `size` parameter and returns all matching results. | |||
There was a problem hiding this comment.
This is not entirely accurate.
- If size/from (pagination) settings aren't set, the search index will "stream" all qualifying results to N1QL which can perform further filtering.
- If
size/limit,from/offsetare set within the search request within the SEARCH function, FTS handles the pagination. - N1QL can hand down LIMIT/OFFSET settings to FTS. If this
limit+offset <= bleveMaxResultWindow- then the FTS index is deemed pageable and N1QL hands down these settings to FTS. If not, then FTS will stream results to N1QL and N1QL will be responsible for pagination and ordering.
I'll let you fix the content here based on the above.
As per Abhinav corrections
| @@ -243,7 +243,7 @@ | |||
| *** xref:fts:fts-architecture-scatter-gather.adoc[Scatter Gather] | |||
| *** xref:fts:fts-architecture-ports-used.adoc[Ports Used By FTS] | |||
| *** xref:fts:fts-rebalance-failover.adoc[Rebalance/Failover] | |||
| ** xref:fts:fts-cluster-operations.adoc[Cluster Level Options] | |||
| ** xref:fts:fts-cluster-options.adoc[Cluster Level Options] | |||
There was a problem hiding this comment.
If you're doing this, you'll be breaking the link without updating the adoc from fts-cluster-operations to fts-cluster-options
There was a problem hiding this comment.
Ah nevermind, I was on an older fork of release/7.0.
abhinavdangeti
approved these changes
Feb 24, 2022
| @@ -243,7 +243,7 @@ | |||
| *** xref:fts:fts-architecture-scatter-gather.adoc[Scatter Gather] | |||
| *** xref:fts:fts-architecture-ports-used.adoc[Ports Used By FTS] | |||
| *** xref:fts:fts-rebalance-failover.adoc[Rebalance/Failover] | |||
| ** xref:fts:fts-cluster-operations.adoc[Cluster Level Options] | |||
| ** xref:fts:fts-cluster-options.adoc[Cluster Level Options] | |||
There was a problem hiding this comment.
Ah nevermind, I was on an older fork of release/7.0.
RayOffiah
pushed a commit
that referenced
this pull request
Feb 21, 2025
* fix syntax error in xref * fix xref to fts-cluster-options.adoc * resolve dead fts link to bleveMaxResultWindow update dead reference from xref:fts:fts-response-object-schema.adoc#request[maximum number of full text search results] to xref:fts:fts-advanced-settings-bleveMaxResultWindow.adoc[bleveMaxResultWindow] * informational update As per Abhinav corrections
RayOffiah
pushed a commit
that referenced
this pull request
Feb 21, 2025
* fix syntax error in xref * fix xref to fts-cluster-options.adoc * resolve dead fts link to bleveMaxResultWindow update dead reference from xref:fts:fts-response-object-schema.adoc#request[maximum number of full text search results] to xref:fts:fts-advanced-settings-bleveMaxResultWindow.adoc[bleveMaxResultWindow] * informational update As per Abhinav corrections (cherry picked from commit 1f26a9a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bad syntax extra fts-
nav.adoc needs to be xref:fts:fts-cluster-options.adoc