Skip to content

DOC-9450: Update SEARCH_META(..) instructions and examples #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

abhinavdangeti
Copy link
Member

No description provided.

@simon-dew
Copy link
Contributor

I don't see how this PR fixes the broken links mentioned in DOC-9450?

@abhinavdangeti abhinavdangeti force-pushed the DOC9450-7.1 branch 5 times, most recently from ddeae34 to 8561ae5 Compare February 18, 2022 15:35

[NOTE]
--
The examples in this page all assume that demonstration full text indexes have been created.
The examples in this page assume that you have a full text search index created with this definition, unless specified otherwise ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The examples in this page assume that you have a full text search index created with this definition, unless specified otherwise ..
The examples in this page assume that you have a full text search index created with this definition, unless specified otherwise.

@@ -350,8 +392,74 @@ WHERE t1.type = "hotel" AND SEARCH(t1.description, "amazing");
----

If the full text search index being queried has its default mapping disabled and has a custom type mapping defined, the query needs to specify the type explicitly.

//The above query uses the demonstration index xref:fts:fts-demonstration-indexes.adoc#travel-sample-index-hotel-description[travel-sample-index-hotel-description], which has the custom type mapping "hotel".
The above query uses the following index definition ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The above query uses the following index definition ..
The above query uses the following index definition:

For more information, refer to xref:fts:fts-quickstart-guide.adoc#preparing-for-full-text-searches[Preparing for Full Text Searches].

[NOTE]
--
The examples in this page all assume that demonstration full text indexes have been created, as described in xref:fts:fts-demonstration-indexes.adoc[Demonstration Indexes].
The examples in this page assume that you have a full text search index created with this definition, unless specified otherwise ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The examples in this page assume that you have a full text search index created with this definition, unless specified otherwise ..
The examples in this page assume that you have a full text search index created with this definition, unless specified otherwise.

@@ -358,7 +400,74 @@ WHERE t1.type = "hotel" AND SEARCH(t1.description, "amazing");
----

If the full text search index being queried has its default mapping disabled and has a custom type mapping defined, the query needs to specify the type explicitly.
The above query uses the demonstration index xref:fts:fts-demonstration-indexes.adoc#travel-sample-index-hotel-description[travel-sample-index-hotel-description], which has the custom type mapping "hotel".
The above query uses the following index definition ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The above query uses the following index definition ..
The above query uses the following index definition:

@Thejas-bhat
Copy link
Contributor

Another small suggestion is perhaps having consistent index definition examples wherever possible. This is in reference to index definitions on line 19 and 403 (in searchfun.adoc and similarly on lines 13 and 395 in fts-searching-from-N1QL.adoc) which differ in sourceType and the segmentVersion specified.

@abhinavdangeti
Copy link
Member Author

A forward merge should cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants