Skip to content

DOC-8132-C6 -- Move C code_snippets module in to clang #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2021
Merged

DOC-8132-C6 -- Move C code_snippets module in to clang #512

merged 2 commits into from
Sep 3, 2021

Conversation

ibsoln
Copy link
Contributor

@ibsoln ibsoln commented Sep 2, 2021

  1. Move the code module from JB's initial commit into modules/clang/ examples/code_snippets; this also removes the preexisting debris from examples/
  2. Add the include:: for the getting-started code into the verify/build page
    https://issues.couchbase.com/browse/DOC-8132
  3. Set {snippets} attribute for new module

borrrden and others added 2 commits September 2, 2021 16:15
@borrrden @ibsoln
Preliminary work on C language documentation snippets
0c46d52
@ibsoln
1. Move the code module from JB's initial commit into modules/clang/ …
2d44d67 
…examples/code_snippets; this also removes the preexisting debris from examples/

2. Add the include:: for  the getting-started code into the verify/build page
https://issues.couchbase.com/browse/DOC-8132
@ibsoln ibsoln requested a review from borrrden September 2, 2021 15:46
@ibsoln
Copy link
Contributor Author

ibsoln commented Sep 2, 2021

Hi @borrrden I've pulled your feature branch into the main docs module in the PR. If you are ok with this then please I'll merge it.
You can work directly in this new location or continue to work in your feature branch; either way I can pull in any changes as-and-when.

@borrrden
Copy link
Member

borrrden commented Sep 3, 2021 •
edited
Loading

I'd prefer not to name this clang as it is confusing. It sounds like it is meant for the clang compiler (https://clang.llvm.org/). What is the issue with using c ?

@ibsoln
Copy link
Contributor Author

ibsoln commented Sep 3, 2021

I'd prefer not to name this clang as it is confusing. It sounds like it is meant for the clang compiler (https://clang.llvm.org/). What is the issue with using c ?

No problem @borrrden . I can rename.

@ibsoln ibsoln merged commit 8d04044 into couchbase:release/3.0 Sep 3, 2021
@ibsoln ibsoln deleted the DOC-8132-C6 branch September 3, 2021 10:17
@ibsoln
Copy link
Contributor Author

ibsoln commented Sep 3, 2021

I've merged that in and will push another PR to rename clang to c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borrrden borrrden Awaiting requested review from borrrden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibsoln @borrrden