fix: remove typescript implementation #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
approved these changes
Aug 15, 2024
DimitrisJim
approved these changes
Aug 21, 2024
This was referenced Aug 27, 2024
mergify bot
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Mar 8, 2025
incidental ## Description CosmJS [dropped support for query proofs](cosmos/cosmjs#1618 (comment)) because [the JS implementation was removed from ics23](cosmos/ics23#353). There is no supported implementation so this removes the feature. It leaves the code structure intact in case we can find another implementation, so the earlier API can be restored. It drops the option entirely from agoric-cli so users aren't shown it in help and autocomplete. ### Security Considerations Loss of client-side proofs. ### Scaling Considerations none ### Documentation Considerations Code comments ### Testing Considerations CI ### Upgrade Considerations I can't find anything that was using it.
This was referenced May 21, 2025
This was referenced Jun 25, 2025
This was referenced Jul 16, 2025
This was referenced Jul 24, 2025
This was referenced Aug 5, 2025
This was referenced Aug 13, 2025
|
fwiw if anyone still needs JS/TS support, I’ve built @gldywn/ics23.js, wasm bindings of the If maintainers are open to it, I'd be glad to open a PR to add a link in the README 👍 |
This was referenced Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove typescript implementation, since there is no known usage of it and it is not actively maintained.