e2e: add missing params tests to CI#4207
Conversation
crodriguezvega
requested review from
AdityaSripal,
DimitrisJim,
charleenfei,
chatton,
colin-axner and
damiannolan
as code owners
| ], | ||
| "test": [ | ||
| "TestClientUpdateProposal_Succeeds", | ||
| "TestClient_Update_Misbehaviour", |
There was a problem hiding this comment.
Noticed this was missing, so I added it for free in this PR.
There was a problem hiding this comment.
I feel like we should drop an underscore TestClientUpdate_Misbehaviour 😅 but its fine!
There was a problem hiding this comment.
I'd be happy with that change too :D, would need to make sure to update all the other json files though
damiannolan
left a comment
damiannolan
left a comment
There was a problem hiding this comment.
Nice one @crodriguezvega 🙌
| ], | ||
| "test": [ | ||
| "TestClientUpdateProposal_Succeeds", | ||
| "TestClient_Update_Misbehaviour", |
There was a problem hiding this comment.
I feel like we should drop an underscore TestClientUpdate_Misbehaviour 😅 but its fine!
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
LGTM thanks @crodriguezvega
| ], | ||
| "test": [ | ||
| "TestClientUpdateProposal_Succeeds", | ||
| "TestClient_Update_Misbehaviour", |
There was a problem hiding this comment.
I'd be happy with that change too :D, would need to make sure to update all the other json files though
4 participants
Description
closes: #2010
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.