Skip to content

fix: ensure testnetApp cleanup on error in testnetify #25660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aljo242 merged 2 commits into from
Dec 9, 2025
Merged

fix: ensure testnetApp cleanup on error in testnetify #25660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
686e4cb
fix: ensure testnetApp cleanup on error in testnetify
MrEeeeet111 Dec 9, 2025
cacda23
fix: ensure testnetApp cleanup on error in testnetify
MrEeeeet111 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion server/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,15 @@ func testnetify(ctx *Context, testnetAppCreator types.AppCreator, db dbm.DB, tra
ctx.Viper.Set(KeyUserPubKey, userPubKey)
testnetApp := testnetAppCreator(ctx.Logger, db, traceWriter, ctx.Viper)

var success bool
defer func() {
if !success {
if err := testnetApp.Close(); err != nil {
ctx.Logger.Error("failed to close testnet app on error", "err", err)
}
}
}()

// We need to create a temporary proxyApp to get the initial state of the application.
// Depending on how the node was stopped, the application height can differ from the blockStore height.
// This height difference changes how we go about modifying the state.
Expand Down Expand Up @@ -975,7 +984,8 @@ func testnetify(ctx *Context, testnetAppCreator types.AppCreator, db dbm.DB, tra
return nil, err
}

return testnetApp, err
success = true
return testnetApp, nil
}

// addStartNodeFlags should be added to any CLI commands that start the network.
Expand Down
Loading