Skip to content

Conversation

@sewqasreedas
Copy link
Contributor

Changes:

  • x/bank: Updated SendKeeper and Keeper interfaces (added missing methods, fixed signatures)
  • x/staking: Added BeforeValidatorSlashed hook, fixed hook order
  • x/mint: Fixed InflationCalculationFn signature (sdk.Context → context.Context)
  • x/epochs: Fixed EpochHooks signature (sdk.Context → context.Context, added error return)
  • x/auth: Fixed AccountKeeperI signature (context type, added missing methods)
  • x/upgrade: Fixed UpgradeHandler signature (Context → context.Context, VersionMap → module.VersionMap)

@aljo242
Copy link
Contributor

aljo242 commented Dec 8, 2025

Can you share your methodology for this?

@sewqasreedas
Copy link
Contributor Author

Opened README files in x/ modules, then grep'd for the actual interface definitions in keeper/.go and types/.go. When the signatures didn't match — wrong context type, missing methods, etc — I updated the docs to match what's actually in the code.

@aljo242
Copy link
Contributor

aljo242 commented Dec 9, 2025

Could you add a script that helps us do that so that we can repeat this process in the future?

@aljo242 aljo242 enabled auto-merge December 10, 2025 17:06
@sewqasreedas
Copy link
Contributor Author

sewqasreedas commented Dec 11, 2025

Sorry, spent some time on this but the results were too noisy to be useful. Probably better to keep it manual for now.

@aljo242 aljo242 added this pull request to the merge queue Dec 17, 2025
Merged via the queue into cosmos:main with commit 9d8d03d Dec 17, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants