Skip to content

chore: reduce codeql time#20158

Merged
tac0turtle merged 4 commits intomainfrom
marko/codeql_reduce
Apr 23, 2024
Merged

chore: reduce codeql time#20158
tac0turtle merged 4 commits intomainfrom
marko/codeql_reduce

Conversation

@tac0turtle
Copy link
Copy Markdown
Contributor

@tac0turtle tac0turtle commented Apr 23, 2024

Description

this pr aims to reduce the codeql time as now its taking a long time


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Workflow Enhancements

    • Improved management of workflow executions by adding concurrency settings and enabling cancellation of in-progress runs in GitHub Actions.
  • Build Process Adjustments

    • Modified the Makefile to streamline the build process by focusing on essential tasks and simplifying the localnet-debug target.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 23, 2024

Walkthrough

Walkthrough

The recent updates aim to optimize workflow management and build processes. Notable enhancements include implementing concurrency controls in GitHub Actions workflows to efficiently manage and cancel concurrent executions. Moreover, the Makefile adjustments streamline the build process by refining task execution flow, prioritizing a more targeted approach to building and tooling setup.

Changes

File Path Change Summary
.github/workflows/...analysis.yml Added concurrency settings for controlling and canceling in-progress workflow runs.
.github/workflows/gosec.yml Expanded trigger branches and introduced concurrency settings for improved workflow management.
Makefile Refined all target to concentrate on tools and build, and simplified localnet-debug.

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 92eb7ee and 6ddea4d.
Files selected for processing (1)
  • .github/workflows/codeql-analysis.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/codeql-analysis.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle tac0turtle marked this pull request as ready for review April 23, 2024 15:41
@tac0turtle tac0turtle requested a review from a team April 23, 2024 15:41
#? all: Run tools build lint test vulncheck
all: tools build lint test vulncheck
#? all: Run tools build
all: build
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? That doesn't look like codeql related

Copy link
Copy Markdown
Contributor Author

@tac0turtle tac0turtle Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeql attempts to run a few build commands one of which is make. So linting and all was running here on top of the other action

@tac0turtle tac0turtle added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 843fc13 Apr 23, 2024
@tac0turtle tac0turtle deleted the marko/codeql_reduce branch April 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants