fix: double close

[mmsqe]

Description

Closes: #13373

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #13400 (2d7b4d5) into main (684ee62) will increase coverage by 0.62%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13400      +/-   ##
==========================================
+ Coverage   54.40%   55.03%   +0.62%     
==========================================
  Files         645      680      +35     
  Lines       54925    57835    +2910     
==========================================
+ Hits        29881    31827    +1946     
- Misses      22645    23342     +697     
- Partials     2399     2666     +267     

Impacted Files	Coverage Δ
snapshots/stream.go	52.72% <ø> (+3.57%)	⬆️
x/distribution/simulation/operations.go	80.64% <0.00%> (-9.68%)	⬇️
orm/encoding/ormkv/index_key.go	62.82% <0.00%> (ø)
orm/encoding/ormfield/int64.go	100.00% <0.00%> (ø)
orm/encoding/ormfield/string.go	86.04% <0.00%> (ø)
orm/model/ormdb/json.go	66.66% <0.00%> (ø)
orm/encoding/ormfield/uint32.go	73.77% <0.00%> (ø)
orm/model/ormtable/batch.go	69.56% <0.00%> (ø)
orm/encoding/ormfield/duration.go	76.31% <0.00%> (ø)
orm/encoding/ormfield/timestamp.go	76.31% <0.00%> (ø)
... and 27 more

[julienrbrt]

Pre-approving. Thank you! I'll rebase #13373 when this is merged then. Better indeed to split the upgrade and this fix.

[julienrbrt]

Can you move the changelog under unreleased?

[odeke-em]

LGTM, thank you @mmsqe! Indeed invoking protoWriter.Close() invokes .Close() on the underlying writer.

[julienrbrt]

@tac0turtle, as discussed in Slack, then we'll need to backport this one in v0.45 and v0.46 along with the bump and the CometBFT migration.