refactor: migrate to cosmos/gogoproto#13070
Conversation
874e4e5 to
441561c
Compare
cosmos/gogoprotobufcosmos/gogoproto
tac0turtle
left a comment
There was a problem hiding this comment.
we should review the changes here https://github.com/cosmos/gogoproto/commits/master before merging this into mainline.
8abc4b1 to
d8b77dd
Compare
Codecov Report
@@ Coverage Diff @@
## main #13070 +/- ##
==========================================
+ Coverage 53.64% 54.05% +0.40%
==========================================
Files 647 655 +8
Lines 55199 56223 +1024
==========================================
+ Hits 29612 30390 +778
- Misses 23215 23401 +186
- Partials 2372 2432 +60
|
amaury1093
left a comment
There was a problem hiding this comment.
Code lgtm, however when I run the makefile commands using 0.9.0, it regenerates to gogo/protobuf. I guess that's why you put 0.10 in the makefile, and waiting for this PR to get merged before tagging 0.10?
If so, I can approve now
Right, I have been generating them with: # How to run manually:
docker build --pull --rm -f "contrib/devtools/Dockerfile" -t cosmossdk-proto:latest "contrib/devtools"
docker run --rm -v $(pwd):/workspace --workdir /workspace cosmossdk-proto sh ./scripts/protocgen.shOnce this is merged, 0.10 will be tagged with the Dockerfile changes. |
tac0turtle
left a comment
There was a problem hiding this comment.
quick glance im not sure we need to replace all instances of goo/proto with cosmos/gogoproto, right?
amaury1093
left a comment
There was a problem hiding this comment.
utACK, but I can test once the docker image is tagged
Description
Closes: #10925
After this is merged, I'll tag cosmossdk.io/api and update all dependencies.
This will remove the indirect dependency of
gogo/protobuf.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change