Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a WebAssembly dependency and a huge chunk of bundle size https://bundlephobia.com/package/@cosmjs/[email protected]
(The other, even more huge chunk is cosmos/cosmjs-types#98)
Closes #584
Closes #907
Closes #964
Closes #1031
Closes #1478
Closes #1585
Related: #1479
Technically, now that there's no longer a quirky requirement to
await sodium.ready
at the start of every function, asynchronous methods could be made synchronous now after this PR.Considered but rejected a faster alternative to
@noble/hashes
Argon2id https://bundlephobia.com/package/[email protected] https://www.npmjs.com/package/@node-rs/argon2But hopefully it just gets standardized in Web Crypto someday and then implemented by Node.js. https://twiss.github.io/webcrypto-modern-algos/#argon2