Upgrade Prometheus #4176
Merged
Upgrade Prometheus #4176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
commented
May 13, 2021
| @@ -226,7 +226,7 @@ func TestIngester_v2Push(t *testing.T) { | |||
|
|
|||
| # HELP cortex_ingester_tsdb_exemplar_last_exemplars_timestamp_seconds The timestamp of the oldest exemplar stored in circular storage. Useful to check for what time range the current exemplar buffer limit allows. This usually means the last timestamp for all exemplars for a typical setup. This is not true though if one of the series timestamp is in future compared to rest series. | |||
| # TYPE cortex_ingester_tsdb_exemplar_last_exemplars_timestamp_seconds gauge | |||
| cortex_ingester_tsdb_exemplar_last_exemplars_timestamp_seconds{user="test"} 1000 | |||
| cortex_ingester_tsdb_exemplar_last_exemplars_timestamp_seconds{user="test"} 1 | |||
There was a problem hiding this comment.
This has been fixed in TSDB. Previously was incorrectly in the milliseconds unit instead of seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I'm upgrading Prometheus and some related deps.
Changes to Prometheus LGTM. Basically it was introduced the exemplars support to remote write. I double checked the
Exemplarmessage definition in ourcortex.protoand matches with the definitive one in Prometheus. This Prometheus upgrade also includes the panic fix we've done in prometheus/prometheus#8723.Other upgraded dependencies:
Checked the CHANGELOG and there's no significant update impacting Cortex.
The minor version bump from 1.4 to 1.5 has been done because
ptypeshave been deprecated and it depends on protobuf 1.26.0.Bug fix release.
Checked the CHANGELOG and nothing particular pops up to my eyes, except for the
HTTPSamplingStrategyFetcherfix done by Joe. Because of this, I've rolled back #4134.Checked the release notes and LGTM.
Checked the release notes and changes shouldn't affect Cortex.
Which issue(s) this PR fixes:
Fixes #3907
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]