Training dataset resource bug #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deliahu
reviewed
Apr 25, 2019
| @@ -41,11 +41,24 @@ Train custom TensorFlow models at scale. | |||
| start_delay_secs: <int> # start evaluating after waiting for this many seconds (default: 120) | |||
| throttle_secs: <int> # do not re-evaluate unless the last evaluation was started at least this many seconds ago (default: 600) | |||
|
|
|||
| compute: | |||
| compute: # Resources for training and evaluations steps | |||
There was a problem hiding this comment.
Maybe mention it's the TensorFlow job? Like Resources for training and evaluations steps (TensorFlow)? Similarly # Resources for constructing training dataset (Spark)? We get Omer's stamp of approval on this
There was a problem hiding this comment.
@ospillinger thoughts on the doc comments?
| @@ -30,6 +30,15 @@ type Quantity struct { | |||
| UserString string | |||
| } | |||
|
|
|||
| func MustNewQuantity(str string) Quantity { | |||
pkg/operator/workloads/data_job.go
Outdated
| @@ -251,12 +251,7 @@ func dataWorkloadSpecs(ctx *context.Context) ([]*WorkloadSpec, error) { | |||
| } | |||
| trainingDatasets = append(trainingDatasets, modelName) | |||
| trainingDatasetIDs.Add(dataset.GetID()) | |||
| dependencyIDs := ctx.AllComputedResourceDependencies(dataset.GetID()) | |||
There was a problem hiding this comment.
I think we still need to append the transformedColumn.Computes since transforming the data happens in the same step as preparing the dataset
deliahu
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56
Checklist:
make testandmake lintcx refreshin an example folder)cx init