Skip to content

Validate access to cortex bucket on deploy #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2019
Merged

Validate access to cortex bucket on deploy #511

merged 2 commits into from
Oct 15, 2019

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Oct 14, 2019

Closes #502

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@deliahu deliahu requested a review from vishalbollu October 14, 2019 03:35
@deliahu deliahu merged commit 26ea4e8 into master Oct 15, 2019
@deliahu deliahu deleted the check-bucket branch October 15, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalbollu vishalbollu vishalbollu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate access to cortex bucket on deploy [.5]
2 participants
@deliahu @vishalbollu