Skip to content

Autocast numpy objects to appropriate type #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2019
Merged

Autocast numpy objects to appropriate type #384

merged 3 commits into from
Aug 27, 2019

Conversation

vishalbollu
Copy link
Contributor

Closes #338

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu August 27, 2019 02:33
deliahu
deliahu reviewed Aug 27, 2019
View reviewed changes
pkg/workloads/cortex/onnx_serve/api.py
)
else:
np_arr = np.array(input_pyobj, dtype=target_dtype)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop the astype() in the sklearn handler and tolist() in the imagenet handler, and confirm they work?

@vishalbollu vishalbollu merged commit f65c9e8 into master Aug 27, 2019
@vishalbollu vishalbollu deleted the autocast-numpy branch August 29, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically cast numpy objects
2 participants
@vishalbollu @deliahu