Skip to content

Add granular pod metrics to the Grafana dashboards #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RobertLucian merged 33 commits into from
Mar 1, 2021
Merged

Add granular pod metrics to the Grafana dashboards #1905

RobertLucian merged 33 commits into from
Mar 1, 2021

Conversation

@RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Feb 24, 2021 •
edited
Loading

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update docs and add any new files to summary.md (view in gitbook after merging)

@RobertLucian RobertLucian added the enhancement New feature or request label Feb 24, 2021
@RobertLucian RobertLucian marked this pull request as draft February 24, 2021 02:39
miguelvr
miguelvr reviewed Feb 24, 2021
View reviewed changes
miguelvr
miguelvr reviewed Feb 24, 2021
View reviewed changes
@RobertLucian RobertLucian marked this pull request as ready for review February 24, 2021 18:35
deliahu
deliahu reviewed Feb 24, 2021
View reviewed changes
deliahu
deliahu reviewed Feb 24, 2021
View reviewed changes
deliahu
deliahu reviewed Feb 24, 2021
View reviewed changes
deliahu
deliahu reviewed Feb 24, 2021
View reviewed changes
miguelvr
miguelvr reviewed Feb 25, 2021
View reviewed changes
@RobertLucian
Copy link
Member Author

RobertLucian commented Feb 25, 2021

Same dashboards for GPU/non-GPU clusters.

@RobertLucian
Merge branch 'master' into feature/pod-metrics
efe39d2
@RobertLucian
Part 1 of addressing PR comments
fa02f34
@RobertLucian
Remove extra word
db83041
@RobertLucian
Merge branch 'master' into feature/pod-metrics
4995d43 
# Conflicts:
#	manager/manifests/operator.yaml.j2
@RobertLucian
Fixes
a98e386
@RobertLucian
Update grafana dashboards
88f2bad
@RobertLucian
Fix merge conflicts from 'master' into feature/pod-metrics
9530b8c 
# Conflicts:
#	pkg/types/clusterconfig/cluster_config_aws.go
#	pkg/types/clusterconfig/cluster_config_gcp.go
@RobertLucian
Fix merge conflicts from 'master' into feature/pod-metrics
25a14f9 
# Conflicts:
#	CONTRIBUTING.md
#	build/images.sh
#	charts/templates/prometheus-monitoring.yaml
#	charts/values.yaml
#	cli/cmd/lib_cluster_config_aws.go
#	dev/versions.md
#	docs/clusters/aws/install.md
#	docs/clusters/gcp/install.md
#	manager/install.sh
#	manager/manifests/prometheus-monitoring.yaml.j2
#	pkg/types/clusterconfig/cluster_config_aws.go
#	pkg/types/clusterconfig/cluster_config_gcp.go
#	pkg/types/clusterconfig/config_key.go
@RobertLucian
Lint
684ada3
@RobertLucian
Fix prometheus monitoring
bafb361
@RobertLucian
Further fixes for grafana dashboards
2dfb6c0
@RobertLucian
Merge branch 'master' into feature/pod-metrics
e7f3ae4
@RobertLucian RobertLucian merged commit 3926728 into master Mar 1, 2021
@RobertLucian RobertLucian deleted the feature/pod-metrics branch March 1, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu deliahu left review comments

@miguelvr miguelvr miguelvr left review comments

+1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RobertLucian @deliahu @vishalbollu @miguelvr