Skip to content

Add onnx support #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jul 5, 2019
Merged

Add onnx support #182

merged 28 commits into from
Jul 5, 2019

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jun 26, 2019

Closes #178, #181

  • docs (round 1)
  • Add pre/postprocessing for tf_api/api.py
  • CLI validations for pre/postprocessor existence for TF and ONNX
  • Cast python types to tensor automatically to make pre/postprocessing optional
  • Validate function signature for pre/post processing functions
  • Merge api.py? (Share code between api.py #202)
  • Autodetect model type (Auto-detect model formats #206)

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart local operator, and run cx refresh in an example folder)
  • Update documentation
  • Update examples
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu July 4, 2019 11:10
@vishalbollu vishalbollu requested a review from 1vn July 4, 2019 20:24
Copy link
Contributor

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuff

@deliahu deliahu changed the title [WIP] Add onnx support Add onnx support Jul 5, 2019
@vishalbollu vishalbollu merged commit bba1500 into master Jul 5, 2019
@vishalbollu vishalbollu deleted the onnx-support branch July 5, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python pre- and post-processing for inference
3 participants