Implemented comma, equal sign and space escaping #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. we will review this asap. At first sight i think that this escape procedure should go in the |
|
@wdalmut Moved it to the WriterTrait as requested ;) |
wdalmut
reviewed
Apr 12, 2017
src/Client.php
Outdated
| $data['points'][0]['fields'] = $values; | ||
| } | ||
|
|
||
| if (isset($data['tags'])) { |
There was a problem hiding this comment.
This file should be reverted to the origin/master version
|
Ah, didn't pay attention there, reverted the client.php to master. |
|
I think that is all good. Can you just squash your 4 commits to a single commit? |
Zwartpet
force-pushed
the
patch/line-protocol
branch
from
27ad695 to
e90e2bd
Compare
|
The inspection completed: 1 updated code elements |
|
I certainly can |
|
👍 thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented escaping for tag keys/values and measurement keys
https://docs.influxdata.com/influxdb/v1.2/write_protocols/line_protocol_reference/#special-characters