Skip to content

fix(SidebarNav): dirty fix for rtl ps scrollingX issue #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018
Merged

fix(SidebarNav): dirty fix for rtl ps scrollingX issue #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@coreui/react",
"version": "2.0.6",
"version": "2.0.7",
"description": "CoreUI React Bootstrap 4 components",
"license": "MIT",
"author": {
Expand Down Expand Up @@ -46,7 +46,7 @@
"reactstrap": "^6.4.0"
},
"peerDependencies": {
"@coreui/coreui": "^2.0.12",
"@coreui/coreui": "^2.0.14",
"react": "16.x"
},
"devDependencies": {
Expand Down
5 changes: 4 additions & 1 deletion src/SidebarNav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,12 @@ class AppSidebarNav extends Component {

const navClasses = classNames(className, 'sidebar-nav');

// ToDo: find better rtl fix
const isRtl = getComputedStyle(document.querySelector('html')).direction === 'rtl'

// sidebar-nav root
return (
<PerfectScrollbar className={navClasses} {...attributes} option={{ suppressScrollX: true }} >
<PerfectScrollbar className={navClasses} {...attributes} option={{ suppressScrollX: !isRtl }} >
<Nav>
{children || this.navList(navConfig.items)}
</Nav>
Expand Down