Skip to content

Conversation

samgabriel
Copy link
Contributor

fixes #606 connected streams should not be recycled as a reference is kept inside some webrtc libraries. The library will use the same MediaStream to publish another track if the user decides to do so causing an error of pluginMediaStream does not exist on the Swift side

@samgabriel
Copy link
Contributor Author

@hthetiot this is continuation of #605 and the fixes from #592

@hthetiot hthetiot added this to the 6.0.16 milestone Nov 19, 2020
@hthetiot hthetiot added the bug label Nov 19, 2020
@hthetiot
Copy link
Contributor

hthetiot commented Nov 19, 2020

@samgabriel let me know when ready for review.
Overall look ok, but I'm not sure that necessary to add the property but I will validate on final review.

@hthetiot
Copy link
Contributor

hthetiot commented Nov 19, 2020

@samgabriel can you handle this review from previous PR here #605 (comment)

trackId and rtcId aren't actually supplied, so this change didn't add any value.

@hthetiot hthetiot self-requested a review November 19, 2020 18:40
@hthetiot
Copy link
Contributor

You may commit www/ build you can generate bit via npm run build.

Copy link
Contributor

@hthetiot hthetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18:48:29] Using gulpfile ~/build/cordova-rtc/cordova-plugin-iosrtc/gulpfile.js
[18:48:29] Starting 'lint'...
[18:48:30] Finished 'lint' after 715 ms
/Users/travis/build/cordova-rtc/cordova-plugin-iosrtc/js/MediaStream.js
437:57 error Delete · prettier/prettier
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the --fix option.
npm ERR!

@hthetiot hthetiot merged commit bdcce33 into cordova-rtc:master Nov 20, 2020
@samgabriel samgabriel deleted the fix/issue-606 branch November 20, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local stream not being sent after MediaStream release
2 participants