-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add TLS support to fetch based networking. #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
this.tls["generateECCPrivateKey"](); | ||
}).catch(e => { | ||
console.log(e); | ||
dbg_log("No TLS library detected."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing LOG_FETCH
<meta name="description" content="Run KolibriOS, Linux or Windows 98 in your browser"> | ||
|
||
<script src="build/v86_all.js?98e7110c2"></script> | ||
<script src="build/mitm.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for preloading?
I don't think I want to take on the large mitm.mjs dependency in the default build of v86. I'd accept the following:
|
} | ||
const queue = this.virtio.queues[queue_id]; | ||
// Full buffer looks like an empty buffer so prevent it from filling | ||
while(queue.count_requests() > queue.size - 2) queue.pop_request(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this into its own commit and write a commit message that explains what gets fixed/changed here?
{ | ||
this.network_adapter = new FetchNetworkAdapter(this.bus, options.net_device); | ||
let parts = relay_url.split(";"); | ||
if(parts[1]) this.network_adapter.cors_proxy = parts[1]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1189 (comment)
No description provided.