Skip to content

Conversation

basicer
Copy link
Collaborator

@basicer basicer commented Jul 3, 2025

No description provided.

this.tls["generateECCPrivateKey"]();
}).catch(e => {
console.log(e);
dbg_log("No TLS library detected.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing LOG_FETCH

<meta name="description" content="Run KolibriOS, Linux or Windows 98 in your browser">

<script src="build/v86_all.js?98e7110c2"></script>
<script src="build/mitm.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for preloading?

@copy
Copy link
Owner

copy commented Jul 22, 2025

I don't think I want to take on the large mitm.mjs dependency in the default build of v86. I'd accept the following:

  • comment out the test (remove mitm.mjs from the makefile)
  • fetch_network.js searches for window.TLS or similar and uses that if present
  • document how a user of v86's api could enable tls support for fetch-based networking by importing mitm.js (and adding it to window if mitm.js doesn't already do that)
  • alternatively pass tls as an object to V86 (instead of going through window)
  • add documentation on how to use this

}
const queue = this.virtio.queues[queue_id];
// Full buffer looks like an empty buffer so prevent it from filling
while(queue.count_requests() > queue.size - 2) queue.pop_request();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this into its own commit and write a commit message that explains what gets fixed/changed here?

{
this.network_adapter = new FetchNetworkAdapter(this.bus, options.net_device);
let parts = relay_url.split(";");
if(parts[1]) this.network_adapter.cors_proxy = parts[1];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants