Skip to content

Vine: Support more thread limits.#3733

Merged
btovar merged 1 commit intocooperative-computing-lab:masterfrom
dthain:vine-thread-vars
Mar 25, 2024
Merged

Vine: Support more thread limits.#3733
btovar merged 1 commit intocooperative-computing-lab:masterfrom
dthain:vine-thread-vars

Conversation

@dthain
Copy link
Copy Markdown
Member

@dthain dthain commented Mar 21, 2024

Proposed changes

Add environment variables to control thread quantity for MKL, VECLIB, BLAS, and NUMEXPR, in addition to the existing OpenMP. Numpy and other systems may use any or all of these depending on how they were compiled.

Post-change actions

Put an 'x' in the boxes that describe post-change actions that you have done.
The more 'x' ticked, the faster your changes are accepted by maintainers.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Did you update the manual to reflect your changes, if appropriate? This action should be done after your changes are approved but not merged.
  • Type Labels Select github labels for the type of this change: bug, enhancement, etc.
  • Product Labels Select github labels for the product affected: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

Additional comments

This section is dedicated to changes that are ambitious or complex and require substantial discussions. Feel free to start the ball rolling.

…tely

for tasks using MKL, BLAS, VECLIB, etc.
Copy link
Copy Markdown
Member

@btovar btovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nice thing about standards is that you have so many to choose from.

@btovar
Copy link
Copy Markdown
Member

btovar commented Mar 25, 2024

Ready to merge?

@dthain
Copy link
Copy Markdown
Member Author

dthain commented Mar 25, 2024

RTM

@btovar btovar merged commit da46921 into cooperative-computing-lab:master Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants