Skip to content

S3: Fix use of HMAC_CTX#3720

Merged
dthain merged 1 commit intocooperative-computing-lab:masterfrom
dthain:fix-s3-ssl
Mar 21, 2024
Merged

S3: Fix use of HMAC_CTX#3720
dthain merged 1 commit intocooperative-computing-lab:masterfrom
dthain:fix-s3-ssl

Conversation

@dthain
Copy link
Copy Markdown
Member

@dthain dthain commented Mar 18, 2024

s3_file_io.c used an older code pattern of allocating HMAC_CTX on the stack,
and the current practice in SSL is to instead use HMAC_CTX_new/free.

Note that this module has a number of other code smells that I am not cleaning up at this moment.
Also, it was not compiled in CI due to the lack of lib curl.

Proposed changes

Please describe your changes (e.g., what problems they attempt to solve, what results are expected, etc.) Additional motivation and context are welcome.
Please also mention relevant issues and pull requests as appropriate.

Post-change actions

Put an 'x' in the boxes that describe post-change actions that you have done.
The more 'x' ticked, the faster your changes are accepted by maintainers.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Did you update the manual to reflect your changes, if appropriate? This action should be done after your changes are approved but not merged.
  • Type Labels Select github labels for the type of this change: bug, enhancement, etc.
  • Product Labels Select github labels for the product affected: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

Additional comments

This section is dedicated to changes that are ambitious or complex and require substantial discussions. Feel free to start the ball rolling.

@dthain dthain added bug For modifications that fix a flaw in the code. infrastructure labels Mar 18, 2024
@dthain dthain requested a review from btovar March 19, 2024 13:08
@dthain
Copy link
Copy Markdown
Member Author

dthain commented Mar 20, 2024

@btovar any objections?

@dthain dthain merged commit a8fd34b into cooperative-computing-lab:master Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For modifications that fix a flaw in the code. infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant