Skip to content

configure: turn on max debug symbols with --debug#3713

Merged
btovar merged 3 commits intocooperative-computing-lab:masterfrom
btovar:configure_fix_debug
Mar 13, 2024
Merged

configure: turn on max debug symbols with --debug#3713
btovar merged 3 commits intocooperative-computing-lab:masterfrom
btovar:configure_fix_debug

Conversation

@btovar
Copy link
Copy Markdown
Member

@btovar btovar commented Mar 13, 2024

Previous --debug only turned on optimizations that could be used with debug. Traditionally we always included debugging symbols.

Proposed changes

Please describe your changes (e.g., what problems they attempt to solve, what results are expected, etc.) Additional motivation and context are welcome.
Please also mention relevant issues and pull requests as appropriate.

Post-change actions

Put an 'x' in the boxes that describe post-change actions that you have done.
The more 'x' ticked, the faster your changes are accepted by maintainers.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Did you update the manual to reflect your changes, if appropriate? This action should be done after your changes are approved but not merged.
  • Type Labels Select github labels for the type of this change: bug, enhancement, etc.
  • Product Labels Select github labels for the product affected: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

Additional comments

This section is dedicated to changes that are ambitious or complex and require substantial discussions. Feel free to start the ball rolling.

btovar added 2 commits March 13, 2024 09:25
Previous --debug only turned on optimizations that could be used with
debug. Traditionally we always included debugging symbols.
@btovar btovar force-pushed the configure_fix_debug branch from 56c8c3b to b473ed5 Compare March 13, 2024 13:26
@btovar btovar force-pushed the configure_fix_debug branch from cbf3feb to 2ef7f93 Compare March 13, 2024 14:46
@btovar btovar force-pushed the configure_fix_debug branch from 78251a1 to c34eeec Compare March 13, 2024 15:23
@btovar btovar merged commit 217e200 into cooperative-computing-lab:master Mar 13, 2024
@btovar btovar deleted the configure_fix_debug branch March 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants