Skip to content

vine: resolve uncertain temp availability issue #3694

Merged
btovar merged 1 commit intocooperative-computing-lab:masterfrom
colinthomas-z80:master
Mar 8, 2024
Merged

vine: resolve uncertain temp availability issue #3694
btovar merged 1 commit intocooperative-computing-lab:masterfrom
colinthomas-z80:master

Conversation

@colinthomas-z80
Copy link
Copy Markdown
Contributor

Proposed changes

Begin with a check to make sure a replica is ready to transfer when we decide the file is available

Post-change actions

Put an 'x' in the boxes that describe post-change actions that you have done.
The more 'x' ticked, the faster your changes are accepted by maintainers.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Did you update the manual to reflect your changes, if appropriate? This action should be done after your changes are approved but not merged.
  • Type Labels Select github labels for the type of this change: bug, enhancement, etc.
  • Product Labels Select github labels for the product affected: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

Additional comments

This section is dedicated to changes that are ambitious or complex and require substantial discussions. Feel free to start the ball rolling.

@colinthomas-z80
Copy link
Copy Markdown
Contributor Author

#3692

@btovar
Copy link
Copy Markdown
Member

btovar commented Mar 8, 2024

This is a step in the right direction, however it may hide a root cause. When the manager stopped scheduling there were no tasks running, therefore there were no tasks running. Further, I waited for about 15min, so any transfer would have completed by then. Thus, either the replica had a pending state which will never progress to ready, or it is already ready and can't be found.

Could it be that this is related to #3695 where a replica in the pending state is never removed after an invalid message?

@btovar btovar self-requested a review March 8, 2024 13:16
Copy link
Copy Markdown
Member

@btovar btovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge?

@btovar btovar merged commit 03bf6ad into cooperative-computing-lab:master Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants