Skip to content

WorkQueue: Fix Coprocess Change Path#3542

Merged
dthain merged 1 commit intocooperative-computing-lab:masterfrom
tphung3:issue_3541
Oct 16, 2023
Merged

WorkQueue: Fix Coprocess Change Path#3542
dthain merged 1 commit intocooperative-computing-lab:masterfrom
tphung3:issue_3541

Conversation

@tphung3
Copy link
Copy Markdown
Contributor

@tphung3 tphung3 commented Oct 16, 2023

Proposed changes

This fixes issue #3541.

Post-change actions

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Did you update the manual to reflect your changes, if appropriate? This action should be done after your changes are approved but not merged.
  • Type Labels Select github labels for the type of this change: bug, enhancement, etc.
  • Product Labels Select github labels for the product affected: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

@dthain
Copy link
Copy Markdown
Member

dthain commented Oct 16, 2023

This makes sense to me. I was a little confused at first, until I remembered that WQ coprocesses execute in the workspace directory, and not within their own task directory. (In TV, a serverless library gets its own task directory.)

That said, it looks like there is some lingering problem with TV serverless...

@tphung3 tphung3 added bug For modifications that fix a flaw in the code. Work Queue labels Oct 16, 2023
@tphung3 tphung3 requested a review from dthain October 16, 2023 20:43
@dthain dthain merged commit a2f2474 into cooperative-computing-lab:master Oct 16, 2023
jdolak pushed a commit to jdolak/cctools that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For modifications that fix a flaw in the code. Work Queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants