Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ore check so it correctly detects git-sourced gems installed using Bundler’s standard directory layout.
Changes:
- Update
ore checkto look for git gems under<vendor>/bundler/gems/<name>-<rev[:12]>instead of<vendor>/gems. - Add a regression test covering detection of a git gem in the Bundler git-gems directory layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/ore/commands/check.go | Adjusts git gem path detection logic and adds a helper for 12-char git revisions. |
| cmd/ore/commands/check_git_test.go | Adds a regression test ensuring ore check passes when git gems are in bundler/gems. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pboling
requested changes
Feb 22, 2026
Member
pboling
left a comment
pboling
left a comment
There was a problem hiding this comment.
Copilot discoveries seem legit.
Align ore check with install path conventions for git gems and add regression coverage for bundler/gems + short revision naming.
seuros
force-pushed
the
fix/check-git-layout
branch
from
67b0c2e to
a62b1dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a small bug with
ore check