Skip to content

test: check for required params on tool defs #6501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Jul 8, 2025

Description

Prevents #6121 from happening again by testing for required properties on our tool defs


Summary by cubic

Added tests to ensure all tool definitions have required parameters defined, preventing missing property errors in the future. Refactored tool imports for better organization.

@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner July 8, 2025 00:58
@Patrick-Erichsen Patrick-Erichsen requested review from sestinj and removed request for a team July 8, 2025 00:58
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 8e9f104
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/686f464c82aa5b00087be48b

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 8, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 3 files and found no issues. Review PR in cubic.dev.

Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great but it is failing. if only we had continuous ai...

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 10, 2025
Copy link

⚠️ Conventional Commit Format

Your commit messages don't follow the conventional commit format, but this won't block your PR from being merged. We recommend downloading this extension if you are using VS Code.

Expected Format:

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants