Skip to content

Fix/#489 #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 24, 2025
Merged

Fix/#489 #513

merged 10 commits into from
Jun 24, 2025

Conversation

Mr-Sunglasses
Copy link
Contributor

fix: #489

@Mr-Sunglasses Mr-Sunglasses force-pushed the fix/#489 branch 2 times, most recently from efa6bee to 77b00ba Compare February 17, 2025 18:48
@lsm5
Copy link
Member

lsm5 commented Apr 30, 2025

/packit build
/packit test

@lsm5
Copy link
Member

lsm5 commented Jun 20, 2025

@inknos PTAL

Signed-off-by: Kanishk Pachauri <[email protected]>
@inknos
Copy link
Contributor

inknos commented Jun 24, 2025

@Mr-Sunglasses good to review now?

@Mr-Sunglasses
Copy link
Contributor Author

@Mr-Sunglasses good to review now?

Yes 🙌

@inknos
Copy link
Contributor

inknos commented Jun 24, 2025

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, Mr-Sunglasses

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inknos
Copy link
Contributor

inknos commented Jun 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 24, 2025
@inknos
Copy link
Contributor

inknos commented Jun 24, 2025

Bot was not helping with adding and removing labels. Thanks @Mr-Sunglasses

@openshift-merge-bot openshift-merge-bot bot merged commit 371ecb8 into containers:main Jun 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] containers_create keyword arg "environment" fails json parse for List[str]
4 participants