Actually record last retry time after reconnecting#2608
Merged
mtrmac merged 1 commit intocontainers:mainfrom Oct 25, 2024
Merged
Actually record last retry time after reconnecting#2608mtrmac merged 1 commit intocontainers:mainfrom
mtrmac merged 1 commit intocontainers:mainfrom
Conversation
Member
|
LGTM |
mtrmac
force-pushed
the
retries-time
branch
2 times, most recently
from
6516e7e to
4ebce02
Compare
Contributor
|
/lgtm |
The code was incorrectly setting it to "never", meaning the bodyReaderMSSinceLastRetry heuristic was never triggered, and, in effect, we would _always_ reconnect on io.ErrUnexpectedEOF or syscall.ECONNRESET . This corrects the code - but it might also make more network failures user-visible instead of silently retried. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was incorrectly setting it to "never", meaning the
bodyReaderMSSinceLastRetryheuristic was never triggered, and, in effect, we would always reconnect onio.ErrUnexpectedEOForsyscall.ECONNRESET.This corrects the code - but it might also make more network failures user-visible instead of silently retried.