-
Notifications
You must be signed in to change notification settings - Fork 223
ci: add govulncheck job #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add govulncheck job #2452
Conversation
The main idea here is to find any possible vulnerabilities in dependencies that would require upgrades. Note that this setup ignores Go stdlib vulnerabilities by using latest Go version (which is a default for govulncheck-action), as this is a library and we should not care much about specific Go version used. Signed-off-by: Kir Kolyshkin <[email protected]>
Reviewer's GuideIntroduce a new GitHub Actions job that runs govulncheck to automatically detect vulnerabilities in Go dependencies. Sequence Diagram: Execution Flow of the New govulncheck JobsequenceDiagram
participant GA as GitHub Actions
participant GCJob as "govulncheck Job"
participant GAction as "golang/govulncheck-action@v1"
GA->>+GCJob: Trigger job execution
GCJob->>+GAction: Execute action
GAction-->>-GCJob: Return results/status
GCJob-->>-GA: Report job completion
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kolyshkin - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, sourcery-ai[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OK this needs more work, draft for now. |
Ideally though, renovate should update dependencies only when govulncheck says so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we not update every dependency? Realistically we need to update anyway and just because it doesn't contain a vulnerability yet doesn't mean it it does not tomorrow. Of course this problem goes both ways...
And there still can be plenty of regular bug fixes we would like to consume.
But really having an action that fails on a PR all of the sudden because some dep needs an update seem wrong? That blocks other people from working on this repo until we update the dep.
Renovate already has security data as well and open updates right away when it finds one (or at least it should, I haven't check the config in a while)
If this is setup to run some nightly interval to report the issues to us sure but I think we already have plenty of tools reporting new security issues so I am not sure what we would gain from this tool.
The main idea here is to find any possible vulnerabilities in dependencies that would require upgrades. This is better than just blindly updating dependencies to their latest versions.
Note that this setup ignores Go stdlib vulnerabilities by using latest Go version (which is a default for govulncheck-action), as this is a library and we should not care much about specific Go version used.
Summary by Sourcery
CI: