Skip to content

Conversation

@fujitatomoya
Copy link
Contributor

exported const EnvCNIPath should have comment (or a comment on this block) or be unexported

Signed-off-by: Tomoya Fujita [email protected]

exported const EnvCNIPath should have comment (or a comment on this block) or be unexported

Signed-off-by: Tomoya Fujita <[email protected]>
@dcbw
Copy link
Member

dcbw commented May 4, 2022

@fujitatomoya looks like the change to return in the usage bit is not intended. Can you add that back? Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.322% when pulling 99eac24 on fujitatomoya:bugfix-20220503-golint-error-cnitool into 08f8596 on containernetworking:main.

@dcbw dcbw merged commit 940e662 into containernetworking:main May 11, 2022
@fujitatomoya
Copy link
Contributor Author

@dcbw thanks for iterating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants