Skip to content

Conversation

@squeed
Copy link
Member

@squeed squeed commented Jun 10, 2024

For plugins that may share resources or resource pools across networks, we should make it explicitly clear that GC must only clean up resources known to be owned by the calling network.

For plugins that may share resources or resource pools across networks,
we should make it explicitly clear that GC must only clean up resources
known to be owned by the calling network.

Signed-off-by: Casey Callendrello <[email protected]>
@squeed squeed requested a review from s1061123 June 10, 2024 16:07
@coveralls
Copy link

Coverage Status

coverage: 63.69%. remained the same
when pulling 2c926b5 on squeed:gc-shared-warning
into ed014fe on containernetworking:main.

Copy link
Contributor

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1061123 s1061123 merged commit e82d996 into containernetworking:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants