Fix faulty json.Marshal behavior for embeds types.NetConf #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionelJouin
reviewed
Jun 3, 2024
Member
LionelJouin
left a comment
LionelJouin
left a comment
There was a problem hiding this comment.
This way the users would need to change types.NetConf with types.NetConfType: https://go.dev/play/p/j2wjAgA_s-K
The current way would still not work: https://go.dev/play/p/fHVOmTrH8p_K
s1061123
changed the title
s1061123
changed the title
Contributor
Author
|
@LionelJouin Updated to avoid to change user side code. |
LionelJouin
approved these changes
Jun 3, 2024
Member
LionelJouin
left a comment
LionelJouin
left a comment
There was a problem hiding this comment.
Looks good: https://go.dev/play/p/7ncmsg8-uL0
Signed-off-by: Tomofumi Hayashi <[email protected]>
Contributor
Author
|
@squeed PTAL? |
squeed
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1096