feat: log success record path when debug #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
PTAL @ktock |
ktock
reviewed
Dec 3, 2021
analyzer/analyzer.go
Outdated
| if err := rc.Record(path); err != nil { | ||
| log.G(ctx).WithError(err).Debugf("failed to record %q", path) | ||
| } | ||
| log.G(ctx).Debugf("success record path %q", path) |
Member
There was a problem hiding this comment.
You can get the full list of recorded path using --record-out option.
Instead of printing all paths, can we just print the succeeded message with the number of recorded paths just before this go func returns?
Contributor
Author
There was a problem hiding this comment.
Done, do u think we should add use with --record-out option to see details with the log?
Signed-off-by: haoyun <[email protected]>
ktock
reviewed
Dec 3, 2021
| go func() { | ||
| var successCount int | ||
| defer func() { | ||
| log.G(ctx).Debugf("success record %d path", successCount) |
Member
There was a problem hiding this comment.
(nit)
Suggested change
| log.G(ctx).Debugf("success record %d path", successCount) | |
| log.G(ctx).Debugf("recorded %d path", successCount) |
ktock
approved these changes
Dec 3, 2021
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it will print path only when error happens. Add log when success record path could help to see which file will be prefetched