Avoid adding ipfs dependencies to github.com/containerd/stargz-snapshotter
#511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Nov 4, 2021
ipfs/go.sum
Outdated
| github.com/hashicorp/golang-lru v0.5.1/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8= | ||
| github.com/hashicorp/golang-lru v0.5.3/go.mod h1:iADmTwqILo4mZ8BN3D2Q6+9jd8WM5uGBxy+E8yxSoD4= | ||
| github.com/hashicorp/golang-lru v0.5.4 h1:YDjusn29QI/Das2iO9M0BHnIbxPeyuCHsjMW+lJfyTc= | ||
| github.com/hashicorp/golang-lru v0.5.4/go.mod h1:iADmTwqILo4mZ8BN3D2Q6+9jd8WM5uGBxy+E8yxSoD4= |
…hotter` Signed-off-by: Kohei Tokunaga <[email protected]>
AkihiroSuda
approved these changes
Nov 4, 2021
Member
|
Can we have a new release soon? |
Member
|
(Before that we should update the containerd lib and dedupe the converter pkg) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module
github.com/containerd/stargz-snapshotteris used by various projects (e.g. BuildKit, k3s, CernVM-FS, ...). We should keep the dependency as minimal as possible.Though IPFS-related logic is experimental and optional as of now, it contains lots of dependencies. We should avoid adding them to
github.com/containerd/stargz-snapshotter.This commit solves this issue by introducing new sub modules for ipfs-related logic.
ipfs: IPFS-related plugins for containerd and stargz-snapshottercmd: Dependencies of binary commands.Additionally, ipfs-related logic is eliminated from
github.com/containerd/stargz-snapshotter/fsby making the remote resolver logic configurable. IPFS dependencies are included inipfsandcmdbut not inmygithub.libinneed.workers.dev/containerd/stargz-snapshotter.This also eliminates the dependency to
github.com/containerd/containerd/apifrommygithub.libinneed.workers.dev/containerd/stargz-snapshotter. This will solve #508.