Make timeout for fetching chunks configurable #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Dec 23, 2020
fs/config/config.go
Outdated
| ValidInterval int64 `toml:"valid_interval"` | ||
| CheckAlways bool `toml:"check_always"` | ||
| ChunkSize int64 `toml:"chunk_size"` | ||
| FetchTimeout int64 `toml:"fetching_timeout"` |
Member
There was a problem hiding this comment.
FetchTimeoutSeconds.
Or can we use time.Duration?
Currently, the timeout for fethcing chunks is 30s but this is too short on some environments. This commit make this configurable on `config.toml` (with `fetching_timeout` option) and extended the default timeout (300s). Signed-off-by: Kohei Tokunaga <[email protected]>
AkihiroSuda
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #226
Currently, the timeout for fethcing chunks is 30s but this is too short on some
environments.
This commit make this configurable on
config.toml(withfetching_timeoutoption) and extended the default timeout (300s).
cc: @mattmoor