optimize: allow dumping monitor log to a file #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
mon-dump
branch
from
f152557 to
df1b919
Compare
AkihiroSuda
force-pushed
the
mon-dump
branch
2 times, most recently
from
b2f86c2 to
4ed13f3
Compare
AkihiroSuda
commented
Dec 22, 2020
Now `ctr-remote image optimize` accepts `--record-out=<FILE>` flag.
This flag dumps the monitor log to a line-deliminated text file.
e.g.,
```
{"path":"etc/passwd","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"etc/group","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"etc/passwd","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"etc/group","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/libz.so.1.2.11","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/libz.so.1.2.11","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/libz.so.1.2.11","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/libz.so.1.2.11","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/libpthread-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
{"path":"usr/lib64/libpthread-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0}
...
{"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2}
{"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2}
{"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2}
{"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2}
{"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2}
{"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2}
{"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2}
```
Future version of optimizer should also support consuming this text file. (`--record-in=<FILE>`)
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
mon-dump
branch
from
4ed13f3 to
902d9d0
Compare
ktock
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
ctr-remote image optimizeaccepts--record-out=<FILE>flag.This flag dumps the monitor log to a line-deliminated text file.
e.g.,
{"path":"etc/passwd","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"etc/group","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"etc/passwd","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"etc/group","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/ld-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/libz.so.1.2.11","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/libz.so.1.2.11","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/libz.so.1.2.11","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/libz.so.1.2.11","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/libpthread-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} {"path":"usr/lib64/libpthread-2.28.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":0} ... {"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2} {"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2} {"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2} {"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2} {"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2} {"path":"usr/java/openjdk-15/lib/server/libjvm.so","manifestDigest":"sha256:02f6b131fbb5a7438e4d5bf8a06317b746c91c8e9d5a75be4d3cec8b69ae498a","layerIndex":2}Future version of optimizer should also support consuming this text file. (
--record-in=<FILE>)