estargz: avoid infinite loop of reference of entries #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, estargz lib makes an infinite reference loop of TOCEntry when the input estargz contains the entry of the root directory itself. As a result, the client walks infinite TOCEntry tree. This commit fixes this issue and adds a test to detect it. This commit also adds a logic to prevent the infinite recursive call of `cacheWithReader`. Signed-off-by: Kohei Tokunaga <[email protected]>
AkihiroSuda
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#220
Currently, estargz lib makes an infinite reference loop of TOCEntry when the
input estargz contains the entry of the root directory itself. As a result, the
client walks infinite TOCEntry tree. This commit fixes this issue and adds a
test to detect it. This commit also adds a logic to prevent the infinite
recursive call of
cacheWithReader.